we used to have two path for rendering a frame#2028
Merged
doutriaux1 merged 3 commits intomasterfrom Jun 22, 2016
Merged
Conversation
the one saving pngs was broken and not preserving pngs two paths are now unified this also fixes zoom on animations. fix #1845
Contributor
Author
Contributor
Author
Contributor
|
How do we test it @doutriaux1 ? |
Contributor
Author
import vcs
import cdms2
import os
f=cdms2.open(os.path.join(vcs.sample_data,"clt.nc"))
s=f("clt",slice(0,12))
x=vcs.init(geometry=(800,600))
x.colormap = "AMIP"
x.plot(s)
x.animate.create(thread_it=1)
x.animate.zoom(2)
#x.animate.run()
raw_input("Press enter")
x.animate.save("crap.mp4") |
Contributor
|
@doutriaux1 Do we have a test that failed before and passes with this change? |
Contributor
Author
|
nope. and animation testing are such a pain... I guess we could edit all of our exisiting animation test and force them to have a different colormap. |
Contributor
|
@doutriaux1 Probably its enough if you only change one. If its easy to do it may be worth it - if not, its fine. |
Contributor
|
LGTM 👍 but I didn't run testing. |
Contributor
|
@doutriaux1 @danlipsa can we merge this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the one saving pngs was broken and not preserving pngs
two paths are now unified
this also fixes zoom on animations.
fix #1845
This change is